Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3433] Fix Manifest Crash #1177

Merged
merged 3 commits into from
Jun 20, 2024
Merged

[ABW-3433] Fix Manifest Crash #1177

merged 3 commits into from
Jun 20, 2024

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Jun 19, 2024

Jira ticket: ABW-3433

Description

  • Fixes the crash (by using a new version of Sargon)
  • Propagates the errors that come from Rust panics in the method modify_manifest_add_guarantees

Notes

Currently this would show an error along the lines of this (if forcing an index out of bounds panic), but we could wrap this in a generic error to hide the message, or leave as is, until the PR that lets users send the error to support:

IMG_19953A9296DD-1

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CyonAlexRDX CyonAlexRDX merged commit 67e7458 into main Jun 20, 2024
6 checks passed
@CyonAlexRDX CyonAlexRDX deleted the ABW-3433_Manifest-crash branch June 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants