Display an abstracted message for Sargon errors #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvleju-rdx
changed the title
matiasbzurovski
approved these changes
Jun 20, 2024
Comment on lines
22
to
25
| var body = await buildBody() | ||
| if let additionalBodyInfo { | ||
| body.append("\n\(additionalBodyInfo)") | ||
| } |
There was a problem hiding this comment.
I would send the additionalBodyInfo to buildBody()
Comment on lines
+1530
to
+1535
| /// Email Support | ||
| public static let emailSupportButtonTitle = L10n.tr("Localizable", "error_emailSupportButtonTitle", fallback: "Email Support") | ||
| /// Please email support to automatically provide debugging info, and get assistance. | ||
| /// Code: %@ | ||
| public static func emailSupportMessage(_ p1: Any) -> String { | ||
| return L10n.tr("Localizable", "error_emailSupportMessage", String(describing: p1), fallback: "Please email support to automatically provide debugging info, and get assistance.\nCode: %@") |
There was a problem hiding this comment.
We need to merge radixdlt/apps-localization-src#411 before otherwise next time Swiftgen runs, these will be deleted
There was a problem hiding this comment.
As a rule, normal PRs should never touch Localizable.strings or L10n.generated.swift, that should only be done in the automatic PRs from the crowdin integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3454
Relates to #168
Description
Notes
If you want to simulate this error from Sargon, you can scan this invalid QR code:
Screenshot