Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Backup Behaviour #1183

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Refine Backup Behaviour #1183

merged 7 commits into from
Jun 25, 2024

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Jun 21, 2024

Description

Pursuant to this discussion, the restore from backup behaviour is fixed and refined by this PR:

  1. If you restore a profile from disk which has iCloud sync turned off, we will no longer try to claim it on iCloud (bugfix)
  2. If you restore a profile that has iCloud sync turned on and claiming on iCloud fails, we will continue to import (bugfix) but Security Center will show a problem
  3. Prior to this, when loading the list of iCloud backups (or migrating keychain backups ahead of loading the list), if something goes wrong we now distinguish between three cases:
  • Not logged in to iCloud, show "Not logged in to iCloud" in the list
  • No internet, show "Network unavailable" in the list
  • Other error (very rare), show "Could not load backups" in the list and the error in an alert

The strings were added here

How to test

(Using Pre-alpha 1.6.1 (1) for now, until this is merged)

  1. Try to restore from a file that has iCloud sync disabled
  2. Try to restore from a file while internet is off
  3. Try to load the list of backups with internet off
  4. Try to load the list of backups while logged out of iCloud
  5. Try to load the list of backups with iCloud for Radix Wallet disabled

image

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggested some name changes

@kugel3 kugel3 merged commit 625751b into main Jun 25, 2024
7 checks passed
@kugel3 kugel3 deleted the claim-on-icloud-fix branch June 25, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants