[ABW-3439] Card Carousel #1187
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // MARK: - AppEventsClient | ||
| public struct AppEventsClient: Sendable { | ||
| public var handleEvent: HandleEvent | ||
|
|
||
| init(handleEvent: @escaping HandleEvent) { | ||
| self.handleEvent = handleEvent | ||
| } | ||
| } | ||
|
|
||
| // MARK: AppEventsClient.HandleEvent | ||
| extension AppEventsClient { | ||
| public typealias HandleEvent = @Sendable (AppEvent) -> Void | ||
| } | ||
|
|
||
| extension DependencyValues { | ||
| public var appEventsClient: AppEventsClient { | ||
| get { self[AppEventsClient.self] } | ||
| set { self[AppEventsClient.self] = newValue } | ||
| } | ||
| } | ||
|
|
||
| // MARK: - AppEvent | ||
| public enum AppEvent: Sendable, Hashable { | ||
| case appStarted | ||
| case walletCreated | ||
| case deepLinkReceived(String) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| extension AppEventsClient: DependencyKey { | ||
| public static let liveValue: AppEventsClient = { | ||
| @Dependency(\.homeCardsClient) var homeCardsClient | ||
|
|
||
| return .init( | ||
| handleEvent: { event in | ||
| switch event { | ||
| case .appStarted: | ||
| homeCardsClient.walletStarted() | ||
| case .walletCreated: | ||
| homeCardsClient.walletCreated() | ||
| case let .deepLinkReceived(value): | ||
| homeCardsClient.deepLinkReceived(value) | ||
| } | ||
| } | ||
| ) | ||
| }() | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // MARK: - AppEventsClient + TestDependencyKey | ||
| extension AppEventsClient: TestDependencyKey { | ||
| public static let previewValue = Self.noop | ||
|
|
||
| public static let testValue = Self( | ||
| handleEvent: unimplemented("\(Self.self).handleEvent") | ||
| ) | ||
| } | ||
|
|
||
| extension AppEventsClient { | ||
| public static let noop = Self( | ||
| handleEvent: { _ in } | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // MARK: - HomeCardsClient | ||
| public struct HomeCardsClient: Sendable { | ||
| public var cards: Cards | ||
| public var removeCard: RemoveCard | ||
| public var walletStarted: WalletStarted | ||
| public var walletCreated: WalletCreated | ||
| public var deepLinkReceived: DeepLinkReceived | ||
|
There was a problem hiding this comment. these should express some command, like There was a problem hiding this comment. ignored as per changes to AppEventClient |
||
|
|
||
| init( | ||
| cards: @escaping Cards, | ||
| removeCard: @escaping RemoveCard, | ||
| walletStarted: @escaping WalletStarted, | ||
| walletCreated: @escaping WalletCreated, | ||
| deepLinkReceived: @escaping DeepLinkReceived | ||
| ) { | ||
| self.cards = cards | ||
| self.removeCard = removeCard | ||
| self.walletStarted = walletStarted | ||
| self.walletCreated = walletCreated | ||
| self.deepLinkReceived = deepLinkReceived | ||
| } | ||
| } | ||
|
|
||
| extension HomeCardsClient { | ||
| public typealias Cards = @Sendable () -> AnyAsyncSequence<[HomeCard]> | ||
| public typealias RemoveCard = @Sendable (HomeCard) -> Void | ||
| public typealias WalletStarted = @Sendable () -> Void | ||
| public typealias WalletCreated = @Sendable () -> Void | ||
| public typealias DeepLinkReceived = @Sendable (String) -> Void | ||
| } | ||
|
|
||
| extension DependencyValues { | ||
| public var homeCardsClient: HomeCardsClient { | ||
| get { self[HomeCardsClient.self] } | ||
| set { self[HomeCardsClient.self] = newValue } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import ComposableArchitecture | ||
|
|
||
| // MARK: - HomeCardsClient + DependencyKey | ||
| extension HomeCardsClient: DependencyKey { | ||
| public static let liveValue: Self = { | ||
| let observer = HomeCardsObserver() | ||
|
|
||
| // We are hardcoding to `.mainnet` because the cards are currently gateway agnostic. In the future, when Profile is integrated into Sargon, it will be Sargon | ||
| // observing the current gateway and defining the networkId to use. | ||
| let manager = HomeCardsManager(networkAntenna: URLSession.shared, networkId: .mainnet, cardsStorage: HomeCardsStorage(), observer: observer) | ||
|
|
||
| return Self( | ||
| cards: { | ||
| observer.subject.eraseToAnyAsyncSequence() | ||
| }, | ||
| removeCard: { card in | ||
| Task { | ||
| try? await manager.cardDismissed(card: card) | ||
| } | ||
| }, | ||
| walletStarted: { | ||
| Task { | ||
| try? await manager.walletStarted() | ||
| } | ||
| }, | ||
| walletCreated: { | ||
| Task { | ||
| try? await manager.walletCreated() | ||
| } | ||
| }, | ||
| deepLinkReceived: { value in | ||
| Task { | ||
| try? await manager.deepLinkReceived(encodedValue: value) | ||
| } | ||
| } | ||
| ) | ||
| }() | ||
| } | ||
|
|
||
| // MARK: - HomeCardsManager + Sendable | ||
| extension HomeCardsManager: @unchecked Sendable {} | ||
|
|
||
| // MARK: - HomeCardsStorage | ||
| private final class HomeCardsStorage: Sargon.HomeCardsStorage { | ||
| @Dependency(\.userDefaults) var userDefaults | ||
GhenadieVP marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| func saveCards(encodedCards: Data) async throws { | ||
| userDefaults.setHomeCards(encodedCards) | ||
| } | ||
|
|
||
| func loadCards() async throws -> Data? { | ||
| userDefaults.getHomeCards() | ||
| } | ||
| } | ||
|
|
||
| // MARK: - HomeCardsObserver | ||
| private final class HomeCardsObserver: Sargon.HomeCardsObserver, Sendable { | ||
| let subject: AsyncCurrentValueSubject<[HomeCard]> = .init([]) | ||
|
|
||
| func handleCardsUpdate(cards: [HomeCard]) { | ||
| subject.send(cards) | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, not 100% sure about this approach. Should
AppEventsClientperform some actions on the events, or should it just propagate the events?In the later case the, HomeCardsClients would listen for the events emitted by the AppEventsClient and perform the actions on its own.
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked this idea a lot, so gave it a try here. However, there seems to be a race condition error since the
.appStartedevent is never received by the listener. I even added this handy method to be called by theAppEventsClienton its initialization, to make sure theHomeCardsClientsubscribes to events before the first one is dispatched, but problem was still present.We can work on some delays but even having the
AppsEventsClientstarting theHomeCardsClient(and whatever other listener client we would have in the future) goes against the whole reasoning behind this change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved with
AsyncReplaySubject