-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCfM bug fixes #1192
RCfM bug fixes #1192
Conversation
...ractionFeature/Children/DappOriginVerification/DappInteractionOriginVerification +View.swift
Outdated
Show resolved
Hide resolved
@@ -919,7 +919,7 @@ | |||
830EA9E92AEBA7C5004C8051 /* EntitiesVisibilityClient+Test.swift in Sources */ = {isa = PBXBuildFile; fileRef = 830EA9E82AEBA7C5004C8051 /* EntitiesVisibilityClient+Test.swift */; }; | |||
831F0CED2C21819000D6F5BF /* Sargon in Frameworks */ = {isa = PBXBuildFile; productRef = 831F0CEC2C21819000D6F5BF /* Sargon */; }; | |||
831F0CEF2C25728E00D6F5BF /* RadixConnectMobileSessionStorage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 831F0CEE2C25728E00D6F5BF /* RadixConnectMobileSessionStorage.swift */; }; | |||
831F0CF22C25897500D6F5BF /* DappInteractionOriginVerification +View.swift in Sources */ = {isa = PBXBuildFile; fileRef = 831F0CF12C25897500D6F5BF /* DappInteractionOriginVerification +View.swift */; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removed the empty space
@@ -171,13 +171,7 @@ struct DappInteractor: Sendable, FeatureReducer { | |||
default: break | |||
} | |||
|
|||
if request.route.isDeepLink { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No request has higher priority
@@ -142,7 +142,7 @@ extension Profile { | |||
let dapp = try validateAuthorizedPersonas(of: unvalidatedAuthorizedDapp) | |||
let networkID = dapp.networkID | |||
let network = try network(id: networkID) | |||
if network.authorizedDapps.contains(dapp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad check, this will do a hash comparison, and when a new persona is choosed for the login, then the hashes will be different, instead the stable dapp def address is checked.
Make the dApp name bold.
Additionally: