RCfM bug fixes #1192
Merged
RCfM bug fixes #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ractionFeature/Children/DappOriginVerification/DappInteractionOriginVerification +View.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
commented
Jul 1, 2024
| @@ -919,7 +919,7 @@ | |||
| 830EA9E92AEBA7C5004C8051 /* EntitiesVisibilityClient+Test.swift in Sources */ = {isa = PBXBuildFile; fileRef = 830EA9E82AEBA7C5004C8051 /* EntitiesVisibilityClient+Test.swift */; }; | |||
| 831F0CED2C21819000D6F5BF /* Sargon in Frameworks */ = {isa = PBXBuildFile; productRef = 831F0CEC2C21819000D6F5BF /* Sargon */; }; | |||
| 831F0CEF2C25728E00D6F5BF /* RadixConnectMobileSessionStorage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 831F0CEE2C25728E00D6F5BF /* RadixConnectMobileSessionStorage.swift */; }; | |||
| 831F0CF22C25897500D6F5BF /* DappInteractionOriginVerification +View.swift in Sources */ = {isa = PBXBuildFile; fileRef = 831F0CF12C25897500D6F5BF /* DappInteractionOriginVerification +View.swift */; }; | |||
There was a problem hiding this comment.
Just removed the empty space
GhenadieVP
commented
Jul 1, 2024
| @@ -171,13 +171,7 @@ struct DappInteractor: Sendable, FeatureReducer { | |||
| default: break | |||
| } | |||
|
|
|||
| if request.route.isDeepLink { | |||
There was a problem hiding this comment.
No request has higher priority
GhenadieVP
commented
Jul 1, 2024
| @@ -142,7 +142,7 @@ extension Profile { | |||
| let dapp = try validateAuthorizedPersonas(of: unvalidatedAuthorizedDapp) | |||
| let networkID = dapp.networkID | |||
| let network = try network(id: networkID) | |||
| if network.authorizedDapps.contains(dapp) { | |||
There was a problem hiding this comment.
Bad check, this will do a hash comparison, and when a new persona is choosed for the login, then the hashes will be different, instead the stable dapp def address is checked.
danvleju-rdx
approved these changes
Jul 1, 2024
matiasbzurovski
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the dApp name bold.
Additionally: