Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Details + NFT Name UI fixes #1201

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Address Details + NFT Name UI fixes #1201

merged 4 commits into from
Jul 8, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Jul 5, 2024

Jira ticket: ABW-3484
Jira ticket: ABW-3487

Description

This PR solves some small UI bugs reported.

Notes

Regarding bug 3484, the solution isn't perfect. This is, if user drags the modal to the top (and hence extend its height), the QR code will still resize while dragging. This is because we want the QR code to take all the available size, and if you increase the modal size then so does the image size. The only way to have it not doing this would be to either:

  • prevent the user from dragging the modal => worse UX
  • make the QR image size static => we would need to either make the view scrollable, or the QR code smaller enough to fit in every screen regardless of the address length

I think the current situation is good enough and better than before this change, but will leave some videos for comparisson.

Before After
RPReplay_Final1720094488.MP4
demo.mov

|

Copy link
Contributor

@danvleju-rdx danvleju-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, doesn't look like a bug anymore!

@GhenadieVP GhenadieVP merged commit 4cbb280 into main Jul 8, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3487 branch July 8, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants