Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3565] Show resource details on Asset Transfer #1211

Merged
merged 10 commits into from
Jul 15, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Jul 11, 2024

Jira ticket: ABW-3565

Description

Allows to show resource details on Asset Transfer flow.

Video

demo.mov

Copy link
Contributor

@GhenadieVP GhenadieVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When showing Stake Units, Stake claim NFTS and pool units, their respective details screen needs to be shown. Those should not be shown as Fungible or NonFungibleToken details.

See Android Demo for reference -> radixdlt/babylon-wallet-android#1048

Copy link
Contributor

@GhenadieVP GhenadieVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Very nice, some minor comments added.

@GhenadieVP GhenadieVP merged commit 57824ff into main Jul 15, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3565-asset-transfer-resource-details branch July 15, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants