Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-3569, ABW-3586] Asset transfer & Transaction review Presenting section UI updates #1214
[ABW-3569, ABW-3586] Asset transfer & Transaction review Presenting section UI updates #1214
Changes from 11 commits
124a6fc
bc5b0ea
1e2927b
fb0fa93
9087e01
badd5de
b22fde5
212eef0
32f606f
17e6cdb
e785fbf
16cd883
590e251
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we check a simpler identifier (such as a String) instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, not sure if we could use
ResourceAddress
since there could be multiple NFTs with the same resource address.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, we cannot use
ResourceAddress
. However, usingResourceBalance
as the id could be quite expensive I guess on long lists.We are already doing it on places with more elements, so I wouldn't say you need to fix it for this (that won't have too many NFTs as in the Assets View).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are adding a
VStack
for each proof, which is pointless. Need to revert the order, as shown in previous commentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right!