[ABW-3522] Create Account flow updates #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbzurovski
commented
Jul 17, 2024
| @@ -44,6 +44,8 @@ public struct AppTextField<FocusValue: Hashable, Accessory: View, InnerAccessory | |||
| let accessory: Accessory | |||
| let innerAccesory: InnerAccessory | |||
|
|
|||
| @State private var isFocused: Bool = false | |||
There was a problem hiding this comment.
My first approach was to use @Environment(\.isFocused), but it didn't work. Therefore, I went with this custom solution that we manually updated the flag with the onEditingChanged callback of the TextField.
I think we could be smarter and use our Focus and some callback when it changes, but given such property is optional, it would be tricky handling it when focus = nil. Open to suggestions if someone comes up with a better idea for this.
danvleju-rdx
approved these changes
Jul 17, 2024
GhenadieVP
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3522
Description
This PR makes the following updates:
NameAccount&Completionviews.AppTextFieldto only add grey border when focused (see comments in code).TooggleViewtitle to have more than one line (so that the Create with Ledger toggle doesn't look trimmed as first video shows).Video
before.mov
after.mov