[ABW-3539] UI Adjustments - Account permission #1221
Conversation
| @@ -44,7 +44,7 @@ extension AccountPermission { | |||
| ) { viewStore in | |||
| GeometryReader { geometry in | |||
| ScrollView { | |||
| VStack(spacing: .medium2) { | |||
| VStack(spacing: .large1) { | |||
There was a problem hiding this comment.
Not sure if this value is correct since Zeplin is indicating a padding to a wrong part of the view
There was a problem hiding this comment.
I figured out the actual distance using an unconventional method :D. The selected text box in the screenshot above has a height of 69pt and 3 rows, so 1 row is 23pt. I subtracted 23 from 63 and got 40. Pretty sure this is the correct distance :)
There was a problem hiding this comment.
but are we sure that 69 represents 3 lines? and not just a random box that happens to look like it represents 3 lines from the Text we need to calculate the distance?
I believe we should push for having updated and consistent designs before making these changes. Not only it would be easier for us, but also state the source of truth if implementation differs among platforms.
There was a problem hiding this comment.
Fair enough, asked Aftab
| Text(L10n.DAppRequest.AccountPermission.updateInSettingsExplanation) | ||
| .foregroundColor(.app.gray2) | ||
| .textStyle(.body1Regular) | ||
| .multilineTextAlignment(.center) | ||
| .padding(.horizontal, .medium2) | ||
| .padding(.top, .large1) |
There was a problem hiding this comment.
Zeplin indicates the distance between the two elements should be 76, would be .large1 + 36 (which we don't have any unit * 9). Still, this distance seems quite arbitrary, so I would confirm with Aftab that is a fixed distance and not that we want it centered (as it currently shows).
There was a problem hiding this comment.
.large1 from VStack spacing + this .large1 will be 80. I recall Aftab agreed that we should round to the nearest multiple of 4.
Regarding fixed distance vs centered, I will confirm with Aftab and the Android team.
There was a problem hiding this comment.
but 76 is also multiple of 4, that could be the expected distance as well
There was a problem hiding this comment.
Discussed with Aftab and he adjusted the spacing to .medium1
GhenadieVP
added
the
DO NOT MERGE
GhenadieVP
removed
the
DO NOT MERGE
Jira ticket: ABW-3539
Description
Updates padding for Account Permission screen.
Account cards updates for
AccountPermissionChooseAccountsare handled here.Screenshot