[ABW-3868] Disable home card animation #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3868
Description
Removes the Home cards animation to avoid weird bug reported in issue.
Notes
Umair mentioned this cannot be consistently reproduced, and in my case I could never reproduce it. Before removing the animation, I've manually modified the code so that the
HomeCardsObserverwould send a cards update every 3 seconds with the same set of cards (in case there was some weird issue in Sargon code that would cause that). Even with that, the animation only happened on first load, as expected, and not every time the cards were set. Therefore, my conclusion is that this is a weird Swift bug and safest thing to do is remove the animation.