Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-3637] Do not preselect account on Transfer + AppTextField fix #1228

Merged
merged 2 commits into from
Jul 22, 2024
Merged

[ABW-3637] Do not preselect account on Transfer + AppTextField fix #1228

merged 2 commits into from
Jul 22, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Jul 19, 2024 •
edited by jira bot
Loading

Jira tickets:
ABW-3637
ABW-3633

Description

This PR solves:

  • bug where users wouldn't be able to scan an account if they had 2 accounts added
  • fix UI bug on AppTextField

Before vs after

Before After
before.mov
after.mov

danvleju-rdx
danvleju-rdx approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@danvleju-rdx danvleju-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GhenadieVP GhenadieVP merged commit 6416ef6 into main Jul 22, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3637-scan-account branch July 22, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhenadieVP GhenadieVP GhenadieVP approved these changes

@danvleju-rdx danvleju-rdx danvleju-rdx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matiasbzurovski @GhenadieVP @danvleju-rdx