[ABW-3649] Improve the address details actions to support increased font size #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbzurovski
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Not part of this, but given we are fixing the view for larger font types I believe we should also make sure that the address is fully displayed on bigger fonts.
This is, edit the fullAddress on line 154 to be as this:
Text(colorisedText)
.fixedSize(horizontal: false, vertical: true)This way it look like the image on the right, and not like the one on the left
| HStack(spacing: .large3) { | ||
| Button(L10n.AddressDetails.copy, image: .copy) { | ||
| FlowLayout(multilineAlignment: .center, spacing: .large3) { | ||
| actionButton(L10n.AddressDetails.copy, image: .copyMedium) { |
There was a problem hiding this comment.
If we are already resizing the image, why not use copy-big (that is 24x24`) and avoid adding a new asset?
| private var actions: some SwiftUI.View { | ||
| HStack(spacing: .large3) { | ||
| Button(L10n.AddressDetails.copy, image: .copy) { | ||
| FlowLayout(multilineAlignment: .center, spacing: .large3) { |
There was a problem hiding this comment.
I believe we should decrease this spacing as well.
There was a problem hiding this comment.
Hmm, not sure how much. Reducing this space will deviate from the design.
GhenadieVP
approved these changes
Jul 26, 2024
matiasbzurovski
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3649
Description
Notes
As shown in screenshot 3, since the screen is not scrollable, the QR code becomes smaller as the font size increases.
Screenshot