Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3642] Associated Resources in Approved dApps #1258

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Aug 1, 2024

Jira ticket: ABW-3652

Description

We should be showing associated tokens and NFTs for dApps, whether showing the dApp from a transaction or the list of approved dApps. It turned out that we filtered them out because the dapp_definitions metadata item was parsed in the wrong way, causing it to always appear to be empty. Specifically, the item is sent as a string collection, rather than a collection of globalAddress, which is what we expected.

There was also a slight update to the visual appearance of the NFT details screen, to make it work better when showing only a resource, without the individual token.

Notes

Since the item dapp_definition is being sent as a globalAddress, it might seem that the fix should be on the Gateway side, for consistency, but this PR will make things work as expected.

How to test

  • Approve a dApp that has associated resources, like RadQuest.
  • Go to the Approved dApps list in Settings
  • --> You should see the resources listed there

Screenshot

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@GhenadieVP GhenadieVP merged commit 4b17b91 into main Aug 1, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3642_Approved-Dapps-Tokens branch August 1, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants