[ABW-3458] NFT page request updates #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvleju-rdx
reviewed
Aug 6, 2024
| @@ -2,7 +2,7 @@ import Sargon | |||
|
|
|||
| // MARK: - OnLedgerEntitiesClient + DependencyKey | |||
| extension OnLedgerEntitiesClient: DependencyKey { | |||
| public static let maximumNFTIDChunkSize = 29 | |||
| public static let maximumNFTIDChunkSize = 100 | |||
There was a problem hiding this comment.
So you are saying that GW might not return pages with the max number of items, even if there are more pages available? Didn't quite understand why this value should change.
There was a problem hiding this comment.
There are two things here:
- This number changes to 100 because such is the value that each page can return now (and not 29 as it previously did).
- The GW will change to potentially return less items than what it fit on one page, even if there are items to return. For example, if there are 250 items, it may return
[100, 80, 70]and not[100, 100, 50](which is what the app, without my change, currently expects and why it wouldn't work if different amount of items were returned).
There was a problem hiding this comment.
Got it, thanks for the clarification
danvleju-rdx
approved these changes
Aug 6, 2024
GhenadieVP
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3458
Description
This PR updates paging mechanism for NFTs. Our current logic was based on the assumptions that the GW would return pages with the max amount of items, and this could change in the future. In other words, if there are 100 elements to load and we were requesting pages of 29 elements, the app assumed the GW would return 4 pages with
[29, 29, 29, 13]elements each. However, GW will change and the amount of pages/elements per page won't be fixed.How to test
Play with different NFT collections and sizes to verify the loading happens correctly every time.