Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-3676] Third party deposits text fix #1268

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[ABW-3676] Third party deposits text fix #1268

merged 2 commits into from
Aug 8, 2024

Conversation

danvleju-rdx
Copy link
Contributor

@danvleju-rdx danvleju-rdx commented Aug 7, 2024 •
edited by jira bot
Loading

Jira ticket: ABW-3676

Description

  • Fixed the text at the top of the screen for the "Allow/Deny Specific Assets" and "Allow Specific Depositors" screens for accounts that have been recovered via MARS.
  • Removed ViewState

Screenshot

Screen Before Screen After
Simulator Screenshot - iPhone 15 Pro Max - 2024-08-07 at 13 01 58 Simulator Screenshot - iPhone 15 Pro Max - 2024-08-07 at 12 55 45
Simulator Screenshot - iPhone 15 Pro Max - 2024-08-07 at 13 02 03 Simulator Screenshot - iPhone 15 Pro Max - 2024-08-07 at 12 55 53

CyonAlexRDX
CyonAlexRDX approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GhenadieVP GhenadieVP merged commit daa1daf into main Aug 8, 2024
6 checks passed
@GhenadieVP GhenadieVP deleted the ABW-3676-third-party-deposits-screens-sub-text-still-showing-of-an-account-that-was-recovered-via-mars branch August 8, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danvleju-rdx @CyonAlexRDX @GhenadieVP