Be lenient when reading dapp_definitions
#1270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From slack
Description
Some resources, like Instapass Badges, encode the
dapp_definitions
metadata item as a global address collection, which seems like the correct approach, whereas most seem to encode it as a string collection. This PR will make the verification mechanism accept both options, but in the long term goal should probably be to use the global address option.Notes
Started a discussion about it here.