[ABW-1315] Radix Connect requset to CE and response from CE #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
commented
Apr 12, 2023
kugel3
reviewed
Apr 12, 2023
kugel3
reviewed
Apr 12, 2023
kugel3
reviewed
Apr 12, 2023
Sources/Core/SharedModels/P2P/ConnectorExtension/ConnectorExtension+Messages.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Apr 12, 2023
Sources/Core/SharedModels/P2P/ConnectorExtension/ConnectorExtension+Messages.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Apr 12, 2023
Sources/Core/SharedModels/P2P/ConnectorExtension/P2P+ToConnectorExtension.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Apr 12, 2023
Sources/Core/SharedModels/P2P/ConnectorExtension/P2P+ToConnectorExtension.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Apr 12, 2023
Sources/Core/SharedModels/P2P/ConnectorExtension/P2P+ToConnectorExtension.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Apr 12, 2023
Sources/Core/SharedModels/P2P/ConnectorExtension/P2P+ToConnectorExtension.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Apr 12, 2023
Sources/Features/AddLedgerNanoFactorSource/AddLedgerNanoFactorSource.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
reviewed
Apr 12, 2023
Sources/Core/SharedModels/P2P/ConnectorExtension/ConnectorExtension+Messages.swift
Outdated
Show resolved
Hide resolved
Sources/Features/AddLedgerNanoFactorSource/AddLedgerNanoFactorSource.swift
Outdated
Show resolved
Hide resolved
Sources/Features/AddLedgerNanoFactorSource/AddLedgerNanoFactorSource.swift
Outdated
Show resolved
Hide resolved
Sources/Features/AddLedgerNanoFactorSource/AddLedgerNanoFactorSource.swift
Outdated
Show resolved
Hide resolved
Sources/Features/DappInteractionFeature/Interactor/DappInteractor.swift
Outdated
Show resolved
Hide resolved
CyonAlexRDX
commented
Apr 13, 2023
| @@ -23,7 +23,8 @@ public struct RadixConnectClient: DependencyKey, Sendable { | |||
| public var addP2PWithPassword: AddP2PWithPassword | |||
|
|
|||
| public var receiveMessages: ReceiveMessages | |||
| public var sendMessage: SendMessage | |||
| public var sendResponse: SendResponse | |||
There was a problem hiding this comment.
A response is for now typically a response back to a Dapp for some "wallet interaction".
CyonAlexRDX
commented
Apr 13, 2023
| @@ -23,7 +23,8 @@ public struct RadixConnectClient: DependencyKey, Sendable { | |||
| public var addP2PWithPassword: AddP2PWithPassword | |||
|
|
|||
| public var receiveMessages: ReceiveMessages | |||
| public var sendMessage: SendMessage | |||
| public var sendResponse: SendResponse | |||
| public var sendRequest: SendRequest | |||
There was a problem hiding this comment.
A request is a new message, typically a request to Connector extension to execute some Ledger Hardware device command, recipient RTC peer is unknown, see SendStrategy below.
CyonAlexRDX
commented
Apr 13, 2023
|
|
||
| extension P2P { | ||
| /// Recipient of sender of an RTC message | ||
| public struct RTCRoute: Sendable, Hashable { |
There was a problem hiding this comment.
A since long missing tuple with the information on HOW to send an RTC message.
CyonAlexRDX
commented
Apr 13, 2023
| /// either a `response` or a `request`. | ||
| public enum RTCMessageFromPeer: Sendable, Hashable { | ||
| /// A response from a peer to some request we have sent over RTC | ||
| case response(Response) |
There was a problem hiding this comment.
@GhenadieVP I was able to remove the RTCRoute from here, was no needed.
GhenadieVP
reviewed
Apr 13, 2023
Sources/Features/AddLedgerNanoFactorSource/AddLedgerNanoFactorSource.swift
Outdated
Show resolved
Hide resolved
Sources/Features/DappInteractionFeature/Interactor/DappInteractor.swift
Outdated
Show resolved
Hide resolved
kugel3
approved these changes
Apr 13, 2023
kugel3
reviewed
Apr 13, 2023
Sources/Core/SharedModels/P2P/ConnectorExtension/ConnectorExtension+Messages.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Apr 14, 2023
Sources/Core/SharedModels/P2P/Application/IncomingMessage/P2P+RTCIncomingMessage.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Apr 14, 2023
Sources/Clients/RadixConnectClient/RadixConnectClient+Live.swift
Outdated
Show resolved
Hide resolved
kugel3
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
CasePath is a nice solution here. Since you're only using the extract part, I first wanted to say that you should take only that as an argument:
extract: @escaping (P2P.RTCMessageFromPeer) -> Case?but since you also use the .. composing functionality it might be worth it!
CyonAlexRDX
changed the title
|
Late to the party, but awesome work 💯 🚀!!! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sorry the confusing branch name...)
Description
This PR "upgrades" RadixConnect to work not only with Dapp request/response but with other request/response as well, e.g. messaging to/from ConnectorExtension for Ledger Nano commands.
Furthermore the Ledger related response and request models have been implemented.
PR submission checklist