[ABW-1301] Ledger genesis factor instances #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
approved these changes
Apr 21, 2023
Sources/Clients/ImportLegacyWalletClient/ImportLegacyWalletClient+Live.swift
Show resolved
Hide resolved
Sources/Clients/LedgerHardwareWalletClient/LedgerHardwareWalletClient+Live.swift
Show resolved
Hide resolved
| @@ -17,6 +17,13 @@ public enum EntityKind: | |||
|
|
|||
| /// Used by Persona | |||
| case identity = 618 | |||
|
|
|||
| public var entityType: any EntityProtocol.Type { | |||
There was a problem hiding this comment.
maybe typeOfEntity would better? it is a bit confusing to have entityType on EntityKind.
There was a problem hiding this comment.
which is why I we call all kinds "Kind", so that we can call a type, "type", it matches the type, but I dont feel too strongly about it.
Tests/Features/CreateEntityFeatureTests/CreationOfEntityTests.swift
Outdated
Show resolved
Hide resolved
Tests/Features/CreateEntityFeatureTests/CreationOfEntityTests.swift
Outdated
Show resolved
Hide resolved
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1301
Description
Adds the ability to create Account and Persona with a Ledger as genesis factor source.
Video
https://rdxworks.slack.com/archives/C031A0V1A1W/p1682073839199249
PR submission checklist