ABW-1286 Thumbnails for NFTs etc #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
force-pushed
the
ABW-1286_Thumbnails
branch
4 times, most recently
from
756ca23
to
f226286
Compare
CyonAlexRDX
reviewed
Apr 28, 2023
Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift
Outdated
Show resolved
Hide resolved
CyonAlexRDX
reviewed
Apr 28, 2023
Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift
Outdated
Show resolved
Hide resolved
CyonAlexRDX
approved these changes
Apr 29, 2023
Sources/Features/AuthorizedDAppsFeature/AuthorizedDApps/AuthorizedDApps.swift
Outdated
Show resolved
Hide resolved
...tDetailsFeature/Components/NonFungibleTokenList/Components/ExpandableRow/ExpandableRow.swift
Outdated
Show resolved
Hide resolved
Sources/Clients/URLFormatterClientLive/URLFormatterClient+Live.swift
Outdated
Show resolved
Hide resolved
Sources/Clients/GatewayAPI/GatewayAPIClient/GatewayAPIClient+Interface.swift
Outdated
Show resolved
Hide resolved
Sources/Clients/GatewayAPI/GatewayAPIClient/GatewayAPIClient+Interface.swift
Outdated
Show resolved
Hide resolved
kugel3
force-pushed
the
ABW-1286_Thumbnails
branch
from
d35ae56
to
7089971
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: paste link here
Description
Adds thumbnails for tokens, NFT resources and the NFT images themselves, in the account view.
Notes
More places to get images in the next PR.
Screenshots
With this PR, these screens get properly downloaded and handled image data:
PR submission checklist