Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security prompt #457

Merged
merged 6 commits into from
Apr 27, 2023
Merged

security prompt #457

merged 6 commits into from
Apr 27, 2023

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Apr 25, 2023 •
edited
Loading

Jira tickets:

Description

  • Added security prompt for accounts which hold XRD tokens. This will need to be updated by determining also if the account is securified.
  • Added the "Legacy" label for accounts which are imported from Olympia

Video

RPReplay_Final1682431626.2.MP4

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

Base automatically changed from fix/ABW-1391-i-os-show-owned-resources-in-home-screen-account-cards to main April 26, 2023 07:23
@GhenadieVP GhenadieVP force-pushed the fix/ABW-1334-i-os-notices-on-accounts-to-support-security-prompting branch from d770d7d to 5df617a Compare April 26, 2023 07:41
@GhenadieVP GhenadieVP marked this pull request as ready for review April 26, 2023 07:45
CyonAlexRDX
CyonAlexRDX approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

kugel3
kugel3 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@kugel3 kugel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work as always, just some magic numbers to replace with constants

@GhenadieVP GhenadieVP merged commit 66864b4 into main Apr 27, 2023
@GhenadieVP GhenadieVP deleted the fix/ABW-1334-i-os-notices-on-accounts-to-support-security-prompting branch April 27, 2023 13:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@kugel3 kugel3 kugel3 approved these changes

@nikola-milicevic nikola-milicevic Awaiting requested review from nikola-milicevic

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GhenadieVP @CyonAlexRDX @kugel3