Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Only submit transaction once #466

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented May 1, 2023

Main currently tries to submit transactions twice, because the SubmitTransaction view "appears" twice, due to it being occluded by another view. This PR fixes this, but should be seen as a temporary measure.

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 requested a review from CyonAlexRDX May 1, 2023 13:10
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! and it just automatically removed you double submit issue?

@kugel3
Copy link
Contributor Author

kugel3 commented May 1, 2023

Well, not automatically, this was the exact cause of it...

@kugel3 kugel3 merged commit 25dd3a3 into main May 1, 2023
@kugel3 kugel3 deleted the fix/only-submit-transaction-once branch May 1, 2023 14:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants