-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-1112] iCloud profile sync #468
Conversation
…-1412_sign_w_ledger
…-1412_sign_w_ledger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Just some micro comments
Sources/Features/OnboardingFeature/Children/Startup/Startup+Reducer.swift
Outdated
Show resolved
Hide resolved
Will do an additional round of testing, after that will merge it. |
@CyonAlexRDX , @GhenadieVP @kugel3 I am going to update the snapshot on Android too. I have a question related to the new header: Are we going to keep the |
We can remove the stored property lastUsedOnDevice is mutable and set when a phone claims the profile, and that date is not the same as profiles |
Ok understood Alex thanks! So |
Jira ticket -> https://radixdlt.atlassian.net/browse/ABW-1112
What was done
Demo
https://drive.google.com/file/d/1Fv5-yIakMsQ40oqMaNoMoMaHWb4eZnea/view?usp=sharing