[ABW-1340, ABW-1474, ABW-1476] Expand Dapp Details #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
approved these changes
May 4, 2023
Sources/Features/AuthorizedDAppsFeature/DappDetails/DappDetails.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
approved these changes
May 4, 2023
| flatMap { .success(transform($0)) } | ||
| } | ||
|
|
||
| public func flatMap<NewValue>(_ transform: (Value) -> Loadable<NewValue>) -> Loadable<NewValue> { |
kugel3
force-pushed
the
ABW-1400_persona-dApps
branch
from
74ab641
to
dbcb997
Compare
kugel3
force-pushed
the
ABW-1340_dApp-details
branch
from
3fcf4d8
to
c22c410
Compare
kugel3
force-pushed
the
ABW-1340_dApp-details
branch
5 times, most recently
from
b04b765
to
d0413b1
Compare
kugel3
changed the title
kugel3
force-pushed
the
ABW-1340_dApp-details
branch
from
f055b70
to
11849a1
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABW-1340 - Show related resources in dApp Details
ABW-1474 - Only show canonical metadata in dApp Details
ABW-1476 - Add "Associated dApps" section to dApp details
Description
In dApp details there should be sections with fungible and non-fungible resources that are related to the dApp.
Notes
This PR is based on ABW-1400, branch wise, so needs to be rebased before merging.
Similarly to that PR, we might want to make the resources tappable, but currently this is blocked by the same reason as over there.
How to test
Screenshot
Coming
PR submission checklist