Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABW-1399 Persona List Fixes #480

Merged
merged 2 commits into from
May 8, 2023
Merged

ABW-1399 Persona List Fixes #480

merged 2 commits into from
May 8, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented May 7, 2023 •
edited by jira bot
Loading

ABW-1399

Description

On the PersonaListView-Profile & PersonaListView-ProfileEdit screens, the following is missing/incorrect

  • The Persona Label is missing from the page title across both screens
  • Persona Name instead of ‘Persona Label’ - as per Zeplin

Notes

The thirds item works as expected

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

CyonAlexRDX
CyonAlexRDX approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kugel3 kugel3 force-pushed the ABW-1399_PersonaList-fixes branch from 6c11d44 to 024e0e3 Compare May 8, 2023 09:08
@kugel3 kugel3 merged commit 8b17f90 into main May 8, 2023
@kugel3 kugel3 deleted the ABW-1399_PersonaList-fixes branch May 8, 2023 10:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kugel3 @CyonAlexRDX @GhenadieVP