Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABW-1386 Edit Persona Fix #481

Merged
merged 2 commits into from
May 8, 2023
Merged

ABW-1386 Edit Persona Fix #481

merged 2 commits into from
May 8, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented May 7, 2023 •
edited
Loading

ABW-1386

Description

The field name heading in Edit Persona should become red when a field has an error.

How to test

  1. Connect a dApp (that requires at least one field, such as First name) with a persona
  2. Go to Settings > Authorized dApps > [some persona]
  3. Tap Edit persona
  4. Remove the string in a required field
    -> The field name heading (upper left) should become red

Screenshot

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 changed the title Abw 1386 edit persona fix ABW-1386 Edit Persona Fix May 7, 2023
@kugel3 kugel3 requested a review from GhenadieVP May 7, 2023 21:32
CyonAlexRDX
CyonAlexRDX approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kugel3 kugel3 merged commit 744a1fc into main May 8, 2023
@kugel3 kugel3 deleted the ABW-1386_Edit-persona-fix branch May 8, 2023 07:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@GhenadieVP GhenadieVP Awaiting requested review from GhenadieVP

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kugel3 @CyonAlexRDX