Highlight Part of String #492
Conversation
| @@ -7,4 +7,34 @@ extension AttributedString { | |||
| public init(_ string: some StringProtocol, foregroundColor: Color) { | |||
| self = with(AttributedString(string)) { $0.foregroundColor = foregroundColor } | |||
| } | |||
|
|
|||
| public init(markdown: some StringProtocol, emphasizedColor: Color) { | |||
There was a problem hiding this comment.
The term "emphasized" can mean both "italic" and "bold", better call it "italic" since that is what you are doing below.
There was a problem hiding this comment.
bold is called stronglyEmphasized in the AttributedString world though.
There was a problem hiding this comment.
But I think something like convertItalicsTo is clearer. emphasizedColor is ambiguous, it could also mean the opposite, that we want to emphasize parts of the string that have the provided color.
| return result | ||
| }() | ||
|
|
||
| static let bold: AttributeContainer = { |
There was a problem hiding this comment.
bold is not used? should be removed? or should als obe used in markdown:emphasizedColor init above?
There was a problem hiding this comment.
It's not used in that helper currently, but we could use both, if we want to e.g. transform bold into one color, and italic into something else. Could also be used in general, those AttributeContainers are very strange and clunky on their own. But I can remove it for now.
Description
There are already several places in the app where we want to do this:
An example would in a dApp request: "The dApp named [dAppName] wants to connect" where the dAppName is of course a parameter. This can easily be handled with our existing localization scheme:
"The dApp named %s wants to connect"
The problem comes when we want to e.g. highlight part of this string, for example the dApp name, in a different color. The way it was solved is to split this in three strings:
"The dApp named"
[dApp name]
"wants to connect"
color them in different colors, and then assemble the result. This works for English, but won't work in other languages with different word order.
The solution in this PR is to use the ability of markdown to mark parts of a text as bold or italic. The PR then adds functionality to convert e.g. italic text to a certain color. Markdown is supported in localized strings, and it's easy for translators to understand.
Concretely, if we wanted to highlight the words "wants to connect" above in pink, we would make this our localised string:
Then in the view code we simply write:
Screenshot
PR submission checklist