Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplified dApp details under PersonaDetails #511

Merged
merged 1 commit into from
May 20, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented May 19, 2023

Shows a simplified version of dApp details when pressing a dApp in the list under Persona Details.

Until we can remake navigation using stacks, this is done by adding a separate feature called SimpleDappDetails, rather than reusing the existing one. This is because we would otherwise have cyclic dependencies.

Video

RPReplay_Final1684494127.MP4

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 requested a review from CyonAlexRDX May 19, 2023 12:40
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kugel3 kugel3 merged commit 62cdfe3 into main May 20, 2023
@kugel3 kugel3 deleted the ABW-XXX_Make-nested-buttons-work branch May 20, 2023 19:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants