-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using different placeholder words in mnemonic #528
Changes from 42 commits
36ef40a
373cabd
2c271c7
afed607
c8ba2fd
72b7f3e
fdcd130
8394a4c
2fb8afc
7f63a19
581e7e2
6fb9754
b226632
cdfc64c
bb1fbd0
0803941
10112e3
3dfbeea
377481e
45326e1
bf508dd
a15c54a
8ef1a8f
2288b9f
b62ec70
facc63e
10f4199
bc03107
158a621
c41ad5c
7a2d6db
4940570
6a98fa2
563ec89
539a1fa
05ff5f7
1f84466
a032d20
c2f10dc
7dfc652
a1f105d
da4bc5d
6e092d0
9bd3ecd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,7 @@ extension EditPersonaField { | |
public var body: some SwiftUI.View { | ||
WithViewStore(store, observe: ViewState.init(state:), send: { .view($0) }) { viewStore in | ||
AppTextField( | ||
primaryHeading: viewStore.primaryHeading, | ||
primaryHeading: .init(text: viewStore.primaryHeading), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was thinking of prominence as a separate property, so that when it's omitted it doesn't affect the primaryHeading parameter, but if you prefer this way then sure. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did not wanna further increase property count in AppTextField. The whole thing is a mess anyway... |
||
secondaryHeading: viewStore.secondaryHeading, | ||
placeholder: "", | ||
text: viewStore.validation( | ||
|
CyonAlexRDX marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the first one basically the same as the words property? And the second one could be computed, using
firstIndex(of:)
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first one is not ordered. I want an ordered set. I tried NonEmpty<OrderedDict, but that does not work because OrderedDict does not conform to Collection.
We have the two of them for fastest possible look up. We don't care about slightly more data, we care about performance. But it was many years ago (I lifted this in from some
Old repo of mine) since ago I wrote this code so yeah, there is room for improvements.