[ABW-1584] offDeviceMnemonic factor source kind
#532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
commented
May 29, 2023
Sources/Features/SettingsFeature/ManageFactorSourcesFeature/ManageFactorSources.swift
Show resolved
Hide resolved
CyonAlexRDX
changed the title
offDeviceMnemonic factor source kind
GhenadieVP
reviewed
May 29, 2023
GhenadieVP
reviewed
May 29, 2023
CyonAlexRDX
commented
May 29, 2023
kugel3
reviewed
May 29, 2023
kugel3
reviewed
May 29, 2023
Sources/Clients/FactorSourcesClient/FactorSourcesClient+Interface.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
reviewed
May 29, 2023
kugel3
reviewed
May 29, 2023
Sources/Clients/FactorSourcesClientLive/FactorSourcesClient+Live.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
reviewed
May 29, 2023
GhenadieVP
reviewed
May 29, 2023
Sources/Features/ImportMnemonic/OffDeviceMnemonicInfo/OffDeviceMnemonicInfo.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
reviewed
May 29, 2023
...ttingsFeature/ImportFromOlympiaLegacyWallet/Coordinator/ImportOlympiaWalletCoordinator.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
reviewed
May 29, 2023
Sources/Features/SettingsFeature/ManageFactorSourcesFeature/ManageFactorSources.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
May 29, 2023
Comment on lines
+116
to
+118
| Labeled("Device ID", value: device.id) | ||
| Labeled("Creation date", value: device.date.ISO8601Format()) | ||
| Labeled("Device", value: device.description.rawValue) |
There was a problem hiding this comment.
Please add FIXME: Strings in every file where strings are added...
There was a problem hiding this comment.
This is Debug Inspect Profile will never ever reach end user :)
kugel3
reviewed
May 29, 2023
kugel3
reviewed
May 29, 2023
| case let .offDeviceMnemonicInfoPrompt(.presented(.delegate(.done(label, description, mnemonicWithPassphrase)))): | ||
| state.offDeviceMnemonicInfoPrompt = nil | ||
| precondition(state.saveInProfileKind == .offDevice) | ||
| return .run { send in |
There was a problem hiding this comment.
this looks like a job for task
There was a problem hiding this comment.
@kugel3 hit refresh :D
already changed into a task :)
kugel3
reviewed
May 29, 2023
kugel3
reviewed
May 29, 2023
Sources/Features/ImportMnemonic/OffDeviceMnemonicInfo/OffDeviceMnemonicInfo+View.swift
Show resolved
Hide resolved
kugel3
reviewed
May 29, 2023
| WithViewStore(store, observe: \.viewState, send: { .view($0) }) { viewStore in | ||
| VStack { | ||
| AppTextField( | ||
| primaryHeading: "Tell a story", |
There was a problem hiding this comment.
sure, but not even sure we wanna have this screen.... I just invented it and asking for input from Matt about it... but putting FIXMEs there :)
kugel3
reviewed
May 29, 2023
Sources/Features/ImportMnemonic/OffDeviceMnemonicInfo/OffDeviceMnemonicInfo.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
May 29, 2023
...ttingsFeature/ImportFromOlympiaLegacyWallet/Coordinator/ImportOlympiaWalletCoordinator.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
May 29, 2023
| @@ -35,15 +35,20 @@ extension ManageFactorSources { | |||
| } | |||
| } | |||
| } | |||
| Button("Import Mnemonic source") { | |||
| viewStore.send(.importMnemonicButtonTapped) | |||
| Button("Import Olympia mnemonic") { | |||
There was a problem hiding this comment.
This is debug screen only, should probably be renamed as such...
kugel3
reviewed
May 29, 2023
Sources/Features/SettingsFeature/ManageFactorSourcesFeature/ManageFactorSources.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
May 29, 2023
kugel3
approved these changes
May 29, 2023
GhenadieVP
approved these changes
May 29, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1584 , ticket 0 in MFA epic.
Signing
Signing with this factor will be implemented in a subsequent PR.
Screenshot
Video
Movie in Slack