[Bug fix] Prevent same Transaction from being commited twice. #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
requested review from
GhenadieVP and
kugel3
and removed request for
GhenadieVP
CyonAlexRDX
changed the title
kugel3
reviewed
May 31, 2023
| public struct ViewState: Equatable { | ||
| // TODO: declare some properties | ||
| } | ||
| public struct ViewState: Equatable {} |
kugel3
reviewed
May 31, 2023
Comment on lines
+26
to
+27
| showApproveButton: transactionWithLockFee != nil, | ||
| canApproveTX: canApproveTX |
kugel3
reviewed
May 31, 2023
| @@ -119,6 +121,7 @@ extension TransactionReview { | |||
| Button(L10n.TransactionReview.approveButtonTitle, asset: AssetResource.lock) { | |||
| viewStore.send(.approveTapped) | |||
| } | |||
| .controlState(viewStore.canApproveTX ? .enabled : .disabled) | |||
There was a problem hiding this comment.
Do we need both "Button visible but disabled", and "Button invisible"?
kugel3
reviewed
May 31, 2023
| @@ -30,18 +31,21 @@ public struct TransactionReview: Sendable, FeatureReducer { | |||
| public var proofs: TransactionReviewProofs.State? = nil | |||
| public var networkFee: TransactionReviewNetworkFee.State? = nil | |||
| public let ephemeralNotaryPrivateKey: Curve25519.Signing.PrivateKey | |||
| public var canApproveTX: Bool = true | |||
There was a problem hiding this comment.
Not visible in beginning as you pointed out. But yeah ought to clean up later
kugel3
reviewed
May 31, 2023
| @@ -198,6 +202,7 @@ public struct TransactionReview: Sendable, FeatureReducer { | |||
|
|
|||
| case .approveTapped: | |||
| guard let transactionWithLockFee = state.transactionWithLockFee else { return .none } | |||
| state.canApproveTX = false | |||
There was a problem hiding this comment.
aha, so this is more of a "already approving TX"? Then perhaps it should be an enum with informatively named cases?
There was a problem hiding this comment.
sure, I can change to status and some enum
There was a problem hiding this comment.
ah actually, can we do it later? I want to change all this code anyway...?
There was a problem hiding this comment.
I am ok with doing this later
There was a problem hiding this comment.
sure, just wanted to make sure i understood the logic
kugel3
approved these changes
May 31, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: paste link here
This is a small yet important security related fix, which prevents users from ever approving, signing and submitting the same transaction twice.
The fix is small, and 100% safe. What we do is that for a given TransactionManifest to review, sign and submit, we generate the transaction
noncein the same context where we have the TransactionManifest, and pass both toTransactionReviewfeature, this is fundamentally different to what we are doing today, which is generate a new nonce everytime Approve TX button is pressed (bad and dangerous and should never have been implemented this way!).For "belt and suspenders", I also persist the Approve Button state in TransactionReview, making sure it cannot be pressed again until tx has failed.
PR submission checklist