ABW-1666 bBlock duplicate NFT transfer

[kugel3]

Jira ticket: ABW-1666

Description

• Blocks the ability to try to send the same NFT to multiple receiving accounts
• Fixes the appearance of collapsed NFT lists

Screenshot

The upper NFT has already been selected for another account

PR submission checklist

• I have tested account to account transfer flow and have confirmed that it works

[GhenadieVP]

LGTM, though I think we might have wanted to still allow users to select the NFT but display an error in AssetTransfer View. Android I think does exactly that.

[kugel3]

We could allow them to tap it and show the error message then. That's why I put the selection blocking logic in the reducer instead of the view, so we can choose what to do. I definitely think we should indicate visually that it's not selectable.

[GhenadieVP]

We could allow them to tap it and show the error message then. That's why I put the selection blocking logic in the reducer instead of the view, so we can choose what to do. I definitely think we should indicate visually that it's not selectable.

I think idea is to follow the same UX as for fungible resources having the total sum going over the balance, in a way sending the same nft to two different accounts is going over the balance.
We could re-iterate this with Matt, but the last consensus was to show the error in the AssetTransfer.

[kugel3]

That's a different UX though. For fungibles, you get told that you're over the limit right away, when you enter the amount. So you get warned right where you can change it. It's not very nice if you have to go back in to a receiving account and change it. Also, it's hard to convey which NFT or NFTs that are duplicated, they might forget before they get in to the asset screen.

I guess we could remove the indication that it has been disabled, and only show an error after they select it, but right there on the asset screen.

[GhenadieVP]

That's a different UX though. For fungibles, you get told that you're over the limit right away, when you enter the amount. So you get warned right where you can change it. It's not very nice if you have to go back in to a receiving account and change it. Also, it's hard to convey which NFT or NFTs that are duplicated, they might forget before they get in to the asset screen.

I guess we could remove the indication that it has been disabled, and only show an error after they select it, but right there on the asset screen.

I am not rooting for any UX, both seem reasonable for me.
I am ok with merging this, and polish later when we do actually get UX input, as we made this kind of decision Ad-Hoc.