Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CreateNewAccount from AssetTransferFlow #552

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Remove CreateNewAccount from AssetTransferFlow #552

merged 4 commits into from
Jun 7, 2023

Conversation

GhenadieVP
Copy link
Contributor

Remove the ability to create a new Account form the AssetTransfer flow since it is very very buggy.

@GhenadieVP GhenadieVP requested a review from kugel3 June 7, 2023 07:13
kugel3
kugel3 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@kugel3 kugel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just remove it, rather than have a flag? Will that boolean ever be dynamically set, even in the future?

CyonAlexRDX
CyonAlexRDX requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just revert the text field change, and possible earlier PRs change to asciiCapable keyboard type? I think I saw Umair reporting strange behaviour of textfield input ?

@GhenadieVP
Copy link
Contributor Author

Shouldn't we just remove it, rather than have a flag? Will that boolean ever be dynamically set, even in the future?

@kugel3 this is a very temporary fix, the CreateAccount flow should really just work and is disabled due to time constraints. Once we have the build sent for review, we need to fix the flow.

@kugel3
Copy link
Contributor

kugel3 commented Jun 7, 2023

Sure, so I would just comment it out, rather than adding a boolean property.

@GhenadieVP
Copy link
Contributor Author

Sure, so I would just comment it out, rather than adding a boolean property.

This is used in other features also, like choose account during dApp Auth request.

@kugel3
Copy link
Contributor

kugel3 commented Jun 7, 2023

Hm, why does that use TransferAccountList?

@GhenadieVP
Copy link
Contributor Author

Hm, why does that use TransferAccountList?

What do you mean? ChooseAccounts is a separate feature, which is used in TransferAccountList.

CyonAlexRDX
CyonAlexRDX approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GhenadieVP GhenadieVP merged commit 9cc75b2 into main Jun 7, 2023
@GhenadieVP GhenadieVP deleted the fix/ABW-1700-i-os-0-2-1-2-issue-when-adding-a-new-account-via-token-transfer-flow-choose-receiving-account-screen branch June 7, 2023 11:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kugel3 kugel3 kugel3 approved these changes

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GhenadieVP @kugel3 @CyonAlexRDX