ABW-1204 Assets appear to not transfer #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
changed the title
GhenadieVP
reviewed
Jun 8, 2023
| Task.detached { | ||
| try await hasTXBeenCommittedSuccessfully(txID) | ||
| if let changedAccounts { | ||
| // FIXME: Ideally we should only have to call the cacheClient here |
There was a problem hiding this comment.
well not necessarily, the accountsPortfolioClient does not react to cache changes.
There was a problem hiding this comment.
Well that is what I mean. I can't simply invalidate the cache since that is not enough to trigger the portfolio fetching, but it would be nicer if it did, because I don't think it's good to have to call accountsPortfolioClient from here.
GhenadieVP
reviewed
Jun 8, 2023
| let changedAccounts: [Profile.Network.Account.EntityAddress]? | ||
|
|
||
| do { | ||
| let decompiledNotarized = try engineToolkitClient.decompileNotarizedTransactionIntent(.init( |
There was a problem hiding this comment.
this is not quite nice, but so be it for now.
There was a problem hiding this comment.
This part was already here, for the debug print. But is there another way to get the addresses?
GhenadieVP
approved these changes
Jun 8, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: ABW-1204
Description
When transferring assets, the asset details view was not reloaded automatically, which made it look like the transaction failed. This is fixed now. Also fixes the issue that NFT resources show up even if we have 0 tokens for them.
Video
RPReplay_Final1686217952.MP4
PR submission checklist