Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several small Fixes #574

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Several small Fixes #574

merged 4 commits into from
Jun 9, 2023

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Jun 9, 2023 •
edited
Loading

Several fixes:

  • Remove checkAccountRecovery after Onboarding is done.
  • Update the for SeedPhrasses.
  • Update Ledger Hardrware Wallet screen in settings.

IMG_0090
IMG_0091
IMG_0092
IMG_0093

@GhenadieVP GhenadieVP changed the title Fixes Several small Fixes Jun 9, 2023
CyonAlexRDX
CyonAlexRDX approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CyonAlexRDX
CyonAlexRDX reviewed Jun 9, 2023
View reviewed changes
Sources/Features/SettingsFeature/DisplayMnemonics/Coordinator/DisplayMnemonics+View.swift
@@ -54,25 +70,15 @@ extension View {
)

return displayMnemonicSheet(with: destinationStore)
.useCautionAlert(with: destinationStore)
}

@MainActor
private func displayMnemonicSheet(with destinationStore: PresentationStoreOf<DisplayMnemonics.Destinations>) -> some View {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove suffix "sheet" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, missed that.

@GhenadieVP GhenadieVP merged commit 762e90a into main Jun 9, 2023
@GhenadieVP GhenadieVP deleted the fixes branch June 9, 2023 14:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GhenadieVP @CyonAlexRDX