-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-1770] Profile Snapshot change of PersonData
to be mainnet ready. NOT CAP21 implementation change.
#585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciek-rdx
approved these changes
Jun 22, 2023
CyonAlexRDX
added
DO NOT MERGE
Merging is blocked or prohibited due to missing specs or other higher priority PRs
and removed
DO NOT MERGE
Merging is blocked or prohibited due to missing specs or other higher priority PRs
labels
Jun 27, 2023
maciek-rdx
changed the title
[ABW-1170] Profile Snapshot change of
[ABW-1770] Profile Snapshot change of Jul 5, 2023
PersonData
to be mainnet ready. NOT CAP21 implementation change.PersonData
to be mainnet ready. NOT CAP21 implementation change.
CyonAlexRDX
removed
the
DO NOT MERGE
Merging is blocked or prohibited due to missing specs or other higher priority PRs
label
Jul 5, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABW-1770
CAUTION
This PR is complete in the sense of Profile Snapshot change ONLY, apart from that it is INCOMPLETE, in regards to:
The above listed features (except Creation and Display Persona) are broken and out of scope of this PR.
My suggestion is once approved, we do NOT merge it into main, but we plan for someone in iOS team to ASAP migrate all the reducers and disable Dapp interaction related to Persona in a new branch and once that is done a new PR into this source branch/PR gets created. And then we merge that into main. With the updated UI for complex persona data kinds like postal address. And then after that work we will ASAP try to finish CAP21 updates and CE to migrate to new format.
SNAPSHOT CHANGE
Persona
changes its data/fields from:To:
Where
PersonaData
is this struct:Where
IdentifiedEntry
is this:Entry
Can be used for homogenous arrays. which is not used by profile or CAP21 (Dapp) but might be useful for tests and debug views.
PostalAddress
is complicated... it is this:Where
PostalAddress.Field
is this:CAP21 ROUGH SKETCH
I've sketched out the most natural CAP21 change for DappInteraction, but it might need some more work. It needs to be documented, communicated. Then this CAP21 changes MUST be implemented by Connector Extension and tested.
But roughly the
PersonaDataRequestItem
looks like this:where
RequestedNumber
is:Which where
RequestedNumber
is what is being used for AccountsRequestItem` in CAP21.And the
Response
is going to be something like:We do NOT share any IDs with the Dapp. We only share the values. The ID is only used exactly like Profile uses
FactorSourceID
, to only saveFactorSource
in one place in Profile. To avoid duplication of data.Demo
This is PLACEHOLDER design, but hey it works...
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-21.at.08.33.44.mp4