ABW-1813 Display NFTs properly #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
force-pushed
the
ABW-1813_Display-NFTs-properly
branch
from
f912b28
to
27c8f69
Compare
CyonAlexRDX
approved these changes
Jun 20, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1813
Description
In Asset Transfer we don’t show the NFT names correctly, and in Transaction Review we don’t show individual NFTs at all.
How to test
Notes
Note that we still can't get the name of individual NFTs
Screenshots
Video
After:
https://github.com/radixdlt/babylon-wallet-ios/assets/123396602/e5bbd77d-34e3-4c9c-9288-ffa71aeecc12
PR submission checklist