ABW-1340 Show dApp detail view from tx review #591
Conversation
| @@ -1,6 +1,7 @@ | |||
| import CreateAuthKeyFeature | |||
| import EditPersonaFeature | |||
| import FeaturePrelude | |||
| import TransactionReviewFeature | |||
There was a problem hiding this comment.
Why is PersonaDetails depending on TransactionReview?
There was a problem hiding this comment.
I wonder the same, looks wrong, same in PersonaDetails (reducer).
There was a problem hiding this comment.
Because I had to move the simplified version of dapp details to TransactionReview. It's used in both places, but if stays in PersonaDetails and we import THAT from TransactionReview then there will be circular dependencies. I would prefer it to be a variant of the normal dapp details, but that's not possible for the same reason. It's also not possible to let it be a separate feature, for the same reason.
The only two alternatives that seem to work are having SimpleDappDetails in TransactionReview and having it BOTH there and in PersonaDetails.
There was a problem hiding this comment.
Maybe do import struct TransactionReviewFeature.SimpleDappDetails.View // Circular dep requires us to have SimpleDapp in TXReview ? and analogously in reducer?
There was a problem hiding this comment.
I ended up having to actually do it in both files, since the two implementations were pretty different it made sense, for now. Rather than spending time making a temporary SimpleDappDetails that can handle both authorized dApps and general dApps.
Sources/Features/TransactionReviewFeature/TransactionReview.swift
Outdated
Show resolved
Hide resolved
|
This is the PR I'm not able to test, since I can't successfully set dapp definition on sandbox. But Dawid Sowa just posted a walkthrough that works for him so i will try that. |
Jira ticket: ABW-1340
Description
NOW TESTED
With this PR it should be possible to tap on a dApp in the Using dApps section of Transaction review, to show the (simplified) dApp details corresponding to that dApp. I have not been able to test it yet.
Video
RPReplay_Final1687775344.MP4
How to test
encounteredAddresses.componentAddresses.userApplicationsproperty on theAnalyzeManifestWithPreviewContextResponse.-> A sheet with some information about the dApp should be shown.
PR submission checklist