ABW-1839 App spills some runtime warnings after the creation of an account on simulator #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciek-rdx
commented
Jun 28, 2023
| @@ -98,6 +98,8 @@ public struct DerivePublicKeys: Sendable, FeatureReducer { | |||
| case .device: | |||
| return .task { | |||
| do { | |||
| try? await Task.sleep(for: .seconds(1)) | |||
There was a problem hiding this comment.
CyonAlexRDX
reviewed
Jun 29, 2023
It's better for sure, as it eliminates warnings and overengineering (the "noop" We're good with 500 + something... 700 is a safe bet I think. Will clean it up and make a proper PR tomorrow 👍 JFYI @CyonAlexRDX - we may also consider future-proofing |
# Conflicts: # App/BabylonWallet.xcodeproj/project.pbxproj
maciek-rdx
changed the title
CyonAlexRDX
approved these changes
Jun 30, 2023
Jira ticket: paste link here
Description
This PR solves the problem with warnings. In the scope I cleaned up the unnecessary
@MainActorattributes, as well as eliminated the noopCreationOfAccount.ViewAction.onFirstTask.Notes
The journey has been discussed here in Slack. I think it would be good to ultimately solve it in a more generic way, but the current implementation should be fine for now.
How to test
I'd suggest trying on at least two devices, just to make sure, as this is kind of a critical path for first time users.
Happy path (or test variation 1)
Unhappy path (or test variation 2)
I'd also suggest smoke-testing for other onboarding paths (restore, ledger).
Video
As requested by @CyonAlexRDX:
RPReplay_Final1688030995.MP4
PR submission checklist