Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily remove commented out code #605

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Temporarily remove commented out code #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24f3890
Temporarily remove commented out code
maciek-rdx Jul 6, 2023
82dd228
Eliminate dead package
maciek-rdx Jul 6, 2023
788de2c
Eliminate Satoshi as a default
maciek-rdx Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ package.addModules([
dependencies: [
"AuthorizedDappsClient",
"CacheClient",
"EditPersonaFeature",
"PersonasFeature",
"GatewayAPI",
],
Expand Down Expand Up @@ -168,7 +167,6 @@ package.addModules([
"CreatePersonaFeature",
"CacheClient",
"ChooseAccountsFeature",
"EditPersonaFeature",
"GatewayAPI",
"GatewaysClient", // get current network
"RadixConnectClient",
Expand Down Expand Up @@ -199,14 +197,6 @@ package.addModules([
],
tests: .no
),
.feature(
name: "EditPersonaFeature",
dependencies: [
"PersonasClient",
"Profile",
],
tests: .no
),
.feature(
name: "FeaturesPreviewerFeature",
featureSuffixDroppedFromFolderName: true,
Expand Down Expand Up @@ -336,7 +326,6 @@ package.addModules([
name: "PersonaDetailsFeature",
dependencies: [
"AuthorizedDappsClient",
"EditPersonaFeature",
"CreateAuthKeyFeature",
"GatewayAPI",
],
Expand Down Expand Up @@ -396,7 +385,6 @@ package.addModules([
"RadixConnectClient",
"ScanQRFeature",
"SecurityStructureConfigurationListFeature",
"EditPersonaFeature",
"ProfileBackupsFeature",
],
tests: .yes()
Expand Down
5 changes: 0 additions & 5 deletions Sources/Features/CreatePersona/Children/CreationOfPersona/CreationOfPersona+Reducer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,7 @@ public struct CreationOfPersona: Sendable, FeatureReducer {
personaData: PersonaData? = nil
) {
self.name = name
#if DEBUG
// FIXME: REMOVE THIS TEMPORARY SETTING OF PERSONA DATA!
self.personaData = .previewValue
#else
self.personaData = .init()
#endif
self.derivePublicKeys = .init(
derivationPathOption: .nextBasedOnFactorSource(
networkOption: .useCurrent,
Expand Down
1 change: 0 additions & 1 deletion Sources/Features/CreatePersona/Children/InfoOfNewPersona/InfoOfNewPersona+Reducer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ public struct NewPersonaInfo: Sendable, FeatureReducer {
public var inputtedName: String
public var sanitizedName: NonEmptyString?

// FIXME: Build support for input of persona "fields"/"entries"!
public var personaData: PersonaData
public var focusedInputField: InputField?

Expand Down
1 change: 0 additions & 1 deletion Sources/Features/CreatePersona/Children/InfoOfNewPersona/InfoOfNewPersona+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ extension NewPersonaInfo {
public let focusedInputField: State.InputField?

public struct SanitizedNameRequirement: Equatable {
// FIXME: Allow input of `PersonaData`!
public let sanitizedName: NonEmptyString
}

Expand Down
1 change: 0 additions & 1 deletion Sources/Features/CreatePersona/Coordinator/CreatePersonaCoordinator+Reducer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ extension CreatePersonaCoordinator {
let .root(.step1_newPersonaInfo(.delegate(.proceed(name, fields)))),
let .path(.element(_, action: .step1_newPersonaInfo(.delegate(.proceed(name, fields))))):

// FIXME: use "fields"
state.path.append(.step2_creationOfPersona(.init(
name: name
)))
Expand Down
2 changes: 0 additions & 2 deletions Sources/Features/DappInteractionFeature/Children/Login/Coordinator/Login+View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ struct Login_Preview: PreviewProvider {
initialState: .previewValue,
reducer: Login()
.dependency(\.accountsClient, .previewValueTwoAccounts())
// FIXME: fix previews with PersonaData
// .dependency(\.authorizedDappsClient, .previewValueOnePersona())
.dependency(\.personasClient, .previewValueTwoPersonas(existing: true))
.dependency(\.personasClient, .previewValueTwoPersonas(existing: false))
)
Expand Down
151 changes: 0 additions & 151 deletions ...Features/DappInteractionFeature/Children/OneTimePersonaData/OneTimePersonaData+View.swift
View file
Open in desktop

This file was deleted.

Loading