Set timeout for test-and-build #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciek-rdx
force-pushed
the
infra/set-timeout
branch
from
916c5c2
to
d5b56fb
Compare
kugel3
approved these changes
Jul 11, 2023
Let's play it safe with 50 mins. There is a bunch of runs that took ~45+ mins. It's still a good improvement over the default 6hrs @kugel3 👍 When it comes to "Unverified" - I don't see an urgency to handle that atm. Will possibly get to it some day... |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It avoids situations where our build gets stuck and we have to pay for idle time... Usually, the CI action takes no more than 38 mins, so setting a
6050 mins timeout ismore thanjust enough.Maybe even 45-50 would be ok?