ABW-1872 Transition to new persona data format/rewire persona from dapp details #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel3
reviewed
Jul 12, 2023
| fatalError() | ||
| guard case let .dApp(dApp, persona) = mode else { return nil } | ||
| return .init( | ||
| name: dApp.displayName?.rawValue ?? L10n.DAppRequest.Metadata.unknownName, |
There was a problem hiding this comment.
in general I think default values like "unknown" should be added as late as possible, ideally in the viewstate.
There was a problem hiding this comment.
Aha, this IS the viewstate, then that's all good.
kugel3
reviewed
Jul 12, 2023
| @@ -127,8 +127,8 @@ public struct PersonasCoordinator: Sendable, FeatureReducer { | |||
| return .task { | |||
| let dApps = try await authorizedDappsClient.getDappsAuthorizedByPersona(persona.id) | |||
| .map(PersonaDetails.State.DappInfo.init) | |||
| let personaDetails = PersonaDetails.State(.general(persona, dApps: .init(uniqueElements: dApps))) | |||
| return .internal(.loadedPersonaDetails(personaDetails)) | |||
| let personaDetailsState = PersonaDetails.State(.general(persona, dApps: .init(uniqueElements: dApps))) | |||
There was a problem hiding this comment.
We don't typically add "state" at the end of variables. Note also that the name of the case is loadedPersonaDetails.
kugel3
approved these changes
Jul 12, 2023
1 task
maciek-rdx
deleted the
ABW-1872-transition-to-new-persona-data-format/rewire-persona-from-dapp-details
branch
|
@maciek-rdx We should NOT use "personaDetailsState", it should be "personaDetails". |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1872
Description
Fixes the crash that you can experience when opening Persona details from dApp Details screen.
How to test
Happy path (or test variation 1)
The app should not crash and display the right data.
Screenshot
PR submission checklist