ABW-1941: Make ansharnet use RCnet V2 dashboard #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulvelaz-rdx
approved these changes
Jul 24, 2023
| @@ -33,7 +33,7 @@ extension LedgerIdentifiable { | |||
| public var address: String { | |||
| switch self { | |||
| case let .transaction(txId): | |||
| return txId.asStr() | |||
| return txId.hex | |||
There was a problem hiding this comment.
@maciek-rdx why do we need this change? is it that the dashboard does not support txId.asStr() lookups?
There was a problem hiding this comment.
Hmmm, I'm not aware of any dashboard-specific considerations... I just adopted what we agreed upon here.
There was a problem hiding this comment.
If I'm not mistaken asStr will provide the HRP version of the tx id
There was a problem hiding this comment.
seems that the dashboard cannot handle the tx id properly...
raulvelaz-rdx
approved these changes
Jul 24, 2023
GhenadieVP
approved these changes
Jul 24, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: here
Description
Check Jira ticket
How to test
Check Jira ticket
Screenshot
PR submission checklist