Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABW-1947: Increase fee #641

Merged
merged 3 commits into from
Jul 24, 2023
Merged

ABW-1947: Increase fee #641

merged 3 commits into from
Jul 24, 2023

Conversation

maciek-rdx
Copy link
Contributor

Jira ticket: paste link here

Description

As discussed here

Screenshot

IMG_69B9B856DBF9-1

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@maciek-rdx maciek-rdx changed the base branch from main to release/rcnet-v2 July 24, 2023 14:48
@micbakos-rdx
Copy link
Contributor

@maciek-rdx This fee needs to be increased into 25 XRD as per this conversation: https://rdxworks.slack.com/archives/C01HK4QFXNY/p1690210365560299?thread_ts=1690204525.323109&cid=C01HK4QFXNY

@micbakos-rdx
Copy link
Contributor

Also @maciek-rdx can you check that this constant is also used to add the lock_fee instruction to manifest and not only to display it in the UI?

@@ -3,7 +3,7 @@ import Foundation

extension BigDecimal {
// FIXME: This should not be used once we can get the actual fees
public static let temporaryStandardFee: BigDecimal = 10
public static let temporaryStandardFee: BigDecimal = 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maciek-rdx please change it to 25

@GhenadieVP GhenadieVP merged commit 6dc7331 into release/rcnet-v2 Jul 24, 2023
2 checks passed
@GhenadieVP GhenadieVP deleted the ABW-1947-increase-fee branch July 24, 2023 19:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants