Pool units in account portfolio #658

GhenadieVP · 2023-08-07T09:21:19Z

Added Pool Units to account portfolio.

Collected the radix network stakes from the Fungible and NonFungible resources.
Collected pools from the Fungible Resources.
Linked with UI.
Update parts of the app to use more granular metadata keys due GW limitations.

How to test:

Add real image for the resource

Align the borders around tokens and nfts

…hind

Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift

kugel3 · 2023-08-08T10:09:51Z

Sources/Clients/GatewayAPI/CreatedModels/ValidatorSubFieldState.swift

+	associatedtype CodingKeyType: CodingKey = Self.CodingKeys
+}
+
+extension KeyedDecodingContainer {


This looks like it's doing something with decoding nested optionals, but how does it differ from the default behaviour?

This is used to handle decoding of empty objects, for some reason the GW instead of sending back null, sends back an empty object. Which probably should be fixed on the backend side

kugel3 · 2023-08-08T10:14:51Z

Sources/Clients/GatewayAPI/GatewayAPI+Utils.swift

+		extract(
+			key: .validator,
+			keyPath: \.asGlobalAddress,
+			transform: ValidatorAddress.init(validatingAddress:)
+		)
+	}


This is very elegant, but if we want to use this pattern in even more places we could consider:

A. Turning extract into a property wrapper or macro
B. Defining a protocol to make the transform redundant, something like InitializableFromAddress

Sources/Clients/GatewayAPI/GatewayAPI+Utils.swift

kugel3 · 2023-08-08T10:25:00Z

Sources/Clients/GatewayAPI/GatewayAPIClient/GatewayAPIClient+Interface.swift

-	public typealias GetEntityDetails = @Sendable (_ addresses: [String]) async throws -> GatewayAPI.StateEntityDetailsResponse
-	public typealias GetEntityMetdata = @Sendable (_ address: String) async throws -> GatewayAPI.EntityMetadataCollection
+	public typealias GetEntityDetails = @Sendable (_ addresses: [String], _ explicitMetadata: [EntityMetadataKey], _ ledgerState: GatewayAPI.LedgerState?) async throws -> GatewayAPI.StateEntityDetailsResponse
+	public typealias GetEntityMetdata = @Sendable (_ address: String, _ explicitMetadata: [EntityMetadataKey]) async throws -> GatewayAPI.EntityMetadataCollection


Elegant solution, even without the OptionSet...

Sources/Clients/GatewayAPI/GatewayAPIClient/GatewayAPIClient+Interface.swift

kugel3

Looks great. Maybe you should even spend the 5 minutes and turn the keys into an OptionalSet manually, it makes both logical and UX sense.

maciek-rdx

Nice one! I requested a bunch of changes here and there, but some of them you can treat more as suggestions. It'd be also nice to retain the working condition of the AssetsFeaturePreview 🙏

Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift

...eatures/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUResource+View.swift

Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/PoolUnit/PoolUnit+View.swift

Sources/Features/AssetsFeature/Components/PoolUnitsList/PoolUnitsList.swift

maciek-rdx

Thanks for changes and comments 🙌

maciek-rdx

~~One sec, the preview still doesn't work... It doesn't crash but displays no data. Looking 👀~~ Nevermind, I'll adjust the preview locally.

maciek-rdx · 2023-08-09T09:44:44Z

Okay, fixing that preview is not as straightforward as I thought 😬 I think we may want to have a broader architectural discussion at some point. For now, I'm going to leave it as is

maciek-rdx added 30 commits July 31, 2023 13:08

Add the tab and a placeholder view

204e5d8

Add one more missing bit

fc0d596

Add the boilerplate for PoolUnitsLis

48958dd

Add the initial boilerplate for the feature

bb03b95

Add LSURow

3b0db0e

Add the Preview

50d3a11

Add some initial preview

e6018a9

Adjust Preview to work with View only

837b6df

Model the ViewState

d4b8182

Make Unit a singleton

c82e855

Display liquid stake units in ForEach

a41f9d5

Flesh out the UI a bit

3bbc877

Make claims look good

af7f038

Add the lok for a single unit

6118432

Add the initial version of the stack behavior

56108bd

Merge branch 'main' into ABW-1807-pool-units

ccd36a2

Add a single card under the header

eecdc51

Simoplify the impelmentation a bit

c57b6be

Add real image for the resource

Fix the spacings

8607bda

Add the component image

0fc7a76

Align the borders around tokens and nfts

Simplify ViewState

d831ed8

Improve the structure of code

7ef35ef

Rename files accordingly

3d864f0

Move view to a separate file

3ca08ca

Structure

5149b40

Adjust the external wiring of the feature

f013c1c

Embed it properly in the UI

6af5e6a

Fix some embedding issues

d1ef148

Make it work with preference propagation for equal header and card be…

7c7f43c

…hind

Move code where it should be

3636075

GhenadieVP and others added 5 commits August 7, 2023 12:18

added calculation

bebc1d8

Cleanup code

de333f9

One last cleanup

e286819

wip

11115f6

Fix the minor issues

864aab2

GhenadieVP commented Aug 8, 2023

View reviewed changes

Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift Outdated Show resolved Hide resolved

GhenadieVP added 3 commits August 8, 2023 07:41

wip

e4b48e3

LSU can have only claim nfts

a071fb6

wip

8a88716

GhenadieVP changed the title ~~WIP Pool units in account portfolio~~ Pool units in account portfolio Aug 8, 2023

wip

562108b

GhenadieVP marked this pull request as ready for review August 8, 2023 09:47

Base automatically changed from ABW-1695-pool-unit-asset-type to main August 8, 2023 10:09

kugel3 reviewed Aug 8, 2023

View reviewed changes

Merge branch 'main' into fix/ABW-2009-pool-units-in-account-portfolio

f3b9700

kugel3 reviewed Aug 8, 2023

View reviewed changes

Sources/Clients/GatewayAPI/GatewayAPI+Utils.swift Outdated Show resolved Hide resolved

kugel3 reviewed Aug 8, 2023

View reviewed changes

Sources/Clients/GatewayAPI/GatewayAPIClient/GatewayAPIClient+Interface.swift Show resolved Hide resolved

kugel3 approved these changes Aug 8, 2023

View reviewed changes

maciek-rdx self-requested a review August 8, 2023 11:09

set instead of array

8444872

maciek-rdx suggested changes Aug 8, 2023

View reviewed changes

review follow up

dbbfe62

maciek-rdx approved these changes Aug 9, 2023

View reviewed changes

maciek-rdx suggested changes Aug 9, 2023

View reviewed changes

maciek-rdx approved these changes Aug 9, 2023

View reviewed changes

GhenadieVP merged commit c380623 into main Aug 10, 2023
5 checks passed

GhenadieVP deleted the fix/ABW-2009-pool-units-in-account-portfolio branch August 10, 2023 06:52

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pool units in account portfolio #658

Pool units in account portfolio #658

GhenadieVP commented Aug 7, 2023 •

edited

Loading

kugel3 Aug 8, 2023

GhenadieVP Aug 8, 2023

kugel3 Aug 8, 2023

kugel3 Aug 8, 2023

kugel3 left a comment

maciek-rdx left a comment

maciek-rdx left a comment

maciek-rdx left a comment •

edited

Loading

maciek-rdx commented Aug 9, 2023

Pool units in account portfolio #658

Pool units in account portfolio #658

Conversation

GhenadieVP commented Aug 7, 2023 • edited Loading

kugel3 Aug 8, 2023

Choose a reason for hiding this comment

GhenadieVP Aug 8, 2023

Choose a reason for hiding this comment

kugel3 Aug 8, 2023

Choose a reason for hiding this comment

kugel3 Aug 8, 2023

Choose a reason for hiding this comment

kugel3 left a comment

Choose a reason for hiding this comment

maciek-rdx left a comment

Choose a reason for hiding this comment

maciek-rdx left a comment

Choose a reason for hiding this comment

maciek-rdx left a comment • edited Loading

Choose a reason for hiding this comment

maciek-rdx commented Aug 9, 2023

GhenadieVP commented Aug 7, 2023 •

edited

Loading

maciek-rdx left a comment •

edited

Loading