Profile - Third-Party deposits #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
commented
Aug 20, 2023
Sources/Profile/Entity/Account.swift
Outdated
| public var depositRule: DepositRule | ||
|
|
||
| /// Denies or allows third-party deposits of specific assets by ignoring the `depositMode` | ||
| public var assetsExceptionList: OrderedDictionary<DepositAddress, DepositAddressExceptionRule> |
There was a problem hiding this comment.
The main reason there is only one list modeled as dictionary, instead of having two list - allow and deny - is to make sure that an Address is either deny or allow.
Having two separate lists would require encapsulating the operations on those, to make sure that the Address is not in both lists.
GhenadieVP
commented
Aug 20, 2023
Sources/Profile/Entity/Account.swift
Outdated
| @@ -169,3 +238,36 @@ extension Profile.Network.Account { | |||
| """ | |||
| } | |||
| } | |||
|
|
|||
| extension Profile.Network.Account.OnLedgerSettings.ThirdPartyDeposits.DepositAddress { | |||
There was a problem hiding this comment.
Custom Encoding/Decodingr required for encoding/decoding NonFungibleGlobalID
CyonAlexRDX
requested changes
Aug 21, 2023
| { | ||
| "resourceAddress" : [ "resource_tdx_21_1tknxxxxxxxxxradxrdxxxxxxxxx009923554798xxxxxxxxxsmgder" ] | ||
| }, | ||
| "allow", |
There was a problem hiding this comment.
The JSON key looks wrong
There was a problem hiding this comment.
Actually that is how a dictionary with object as a key is encoded. While this works, it is not ideal, reworked with my latest commit.
giannis-rdx
approved these changes
Aug 22, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Third-Party deposits models to Profile