Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grape update #683

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Grape update #683

merged 8 commits into from
Aug 23, 2023

Conversation

GhenadieVP
Copy link
Contributor

Updated:

  • EngineToolkit to latest Grape version.
  • GW to latest Grape version.

GhenadieVP
GhenadieVP commented Aug 23, 2023
View reviewed changes
Sources/Features/TransactionReviewFeature/SelectFeePayer/SelectFeePayer+View.swift
@@ -75,15 +75,6 @@ extension SelectFeePayer {
.buttonStyle(.primaryRectangular)
}
}
.footer {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad merge conflict resolution ended up in having to footers...

CyonAlexRDX
CyonAlexRDX approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also change Default Radix.Gateway ??

@GhenadieVP
Copy link
Contributor Author

LGTM!

Also change Default Radix.Gateway ??

Done.

@GhenadieVP GhenadieVP merged commit 8d8796f into main Aug 23, 2023
6 checks passed
@GhenadieVP GhenadieVP deleted the grape_update branch August 23, 2023 12:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@kugel3 kugel3 kugel3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GhenadieVP @CyonAlexRDX @kugel3