ABW-2077 Sign Proof biometric authentication requires 2x biometric scan #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
reviewed
Aug 30, 2023
Sources/Features/DappInteractionFeature/Coordinator/DappInteractionFlow.swift
Outdated
Show resolved
Hide resolved
maciek-rdx
added
the
DO NOT MERGE
|
Merge only after @umair-rdx confirms that it works fine |
CyonAlexRDX
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Free to merge after testing proves it works. But might be hard until RCnetv3 is merged in here, because Grape Dashboard is broken, cannot send proper Persona data requests, and @xstelea is working on a fix for RCNetv3 Dashboard, see https://rdxworks.slack.com/archives/C03JJFEBR0V/p1693416811136369?thread_ts=1693407582.814709&cid=C03JJFEBR0V
CyonAlexRDX
requested changes
Aug 31, 2023
Sources/Features/DappInteractionFeature/Coordinator/DappInteractionFlow.swift
Outdated
Show resolved
Hide resolved
maciek-rdx
force-pushed
the
ABW-2077-Sign-Proof-biometric
branch
from
82238c8
to
49550bb
Compare
CyonAlexRDX
reviewed
Sep 5, 2023
Sources/Features/DappInteractionFeature/Coordinator/DappInteractionCoordinator+View.swift
Outdated
Show resolved
Hide resolved
CyonAlexRDX
reviewed
Sep 5, 2023
Sources/Features/DappInteractionFeature/Coordinator/DappInteractionCoordinator+View.swift
Outdated
Show resolved
Hide resolved
CyonAlexRDX
reviewed
Sep 5, 2023
Sources/Features/DappInteractionFeature/Coordinator/DappInteractionFlow.swift
Outdated
Show resolved
Hide resolved
CyonAlexRDX
approved these changes
Sep 5, 2023
maciek-rdx
removed
the
DO NOT MERGE
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-2077
Notes
Purely SwiftUI issue. 0.1s seems to be good enough. It would be good to see if iOS 17 fixes that issue.
Video recording
Screen.Recording.2023-09-05.at.11.25.22.mov
PR submission checklist