Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-2124] transaction review loading #699

Merged
merged 11 commits into from
Aug 31, 2023
Merged

[ABW-2124] transaction review loading #699

merged 11 commits into from
Aug 31, 2023

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Aug 31, 2023

Jira ticket: paste link here

Description

  • Load asset details only once
  • Fix broken NFT images in transaction review
  • Correct image and ID for NFTs in transaction review
  • Fix bug where asset transfer for NFTs shows nothing at all
  • Properly apply deposit guarantees
  • Load tags for newly created resources
  • Show navigation bar for NFT details in Transaction Review
  • Proper top spacing in Settings

Screenshot

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 force-pushed the ABW-2124_Transaction-review-loading branch from 6a81106 to 589cfaa Compare August 31, 2023 13:35
@kugel3 kugel3 force-pushed the ABW-2124_Transaction-review-loading branch from 589cfaa to 30350b4 Compare August 31, 2023 13:36
CyonAlexRDX
CyonAlexRDX approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have tested locally, worked fine!

maciek-rdx
maciek-rdx reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@maciek-rdx maciek-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one mild suggestion.

Sources/Features/TransactionReviewFeature/TransactionReview.swift Show resolved Hide resolved
Sources/Features/TransactionReviewFeature/TransactionReview.swift Show resolved Hide resolved
@maciek-rdx maciek-rdx merged commit 4a6a7c9 into main Aug 31, 2023
5 checks passed
@maciek-rdx maciek-rdx deleted the ABW-2124_Transaction-review-loading branch August 31, 2023 14:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@maciek-rdx maciek-rdx maciek-rdx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kugel3 @CyonAlexRDX @maciek-rdx