Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable redact/privacySensitive in import mnemonic words since it was… #707

Merged

Conversation

CyonAlexRDX
Copy link
Contributor

… buggy and prevented display of words.

Jira ticket: paste link here

Complements / depends on / relates to #link to other PR

Description

This PR solves / fixes / adds / includes functionality 1 and functionality 2.

Notes

Additional notes.

How to test

Happy path (or test variation 1)

  1. Step 1
  2. Step 2
  3. Verify

Unhappy path (or test variation 2)

  1. Step 1
  2. Step 2
  3. Verify

Screenshot

Screen 1 Before Screen 1 After
paste link here paste link here

Video

paste link here

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

Copy link
Contributor

@kugel3 kugel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't just disable, it removes all the redaction code. Which is fine with me, just pointing that out.

@CyonAlexRDX
Copy link
Contributor Author

git log -S "redacted" will find it again, or finding this PR :) so best to remove all the code which is not anymore needed.

@CyonAlexRDX CyonAlexRDX merged commit 002e15b into main Sep 4, 2023
5 checks passed
@CyonAlexRDX CyonAlexRDX deleted the ABW-2182_stop_redacting_mnemonic_word_on_app_inactive branch September 4, 2023 13:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants